Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightsail: Fix regex name validation #33405

Merged
merged 2 commits into from
Sep 11, 2023
Merged

lightsail: Fix regex name validation #33405

merged 2 commits into from
Sep 11, 2023

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Sep 11, 2023 •
edited
Loading

Description

Relations

Closes #33386
Relates #32289

References

Output from Acceptance Testing

% make t T=TestAccLightsailCertificate_basic K=lightsail
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20 -run='TestAccLightsailCertificate_basic'  -timeout 180m
=== RUN   TestAccLightsailCertificate_basic
=== PAUSE TestAccLightsailCertificate_basic
=== CONT  TestAccLightsailCertificate_basic
--- PASS: TestAccLightsailCertificate_basic (58.16s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lightsail	59.917s
% make t T=TestAccLightsailDisk K=lightsail P=4
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 4 -run='TestAccLightsailDisk'  -timeout 180m
=== RUN   TestAccLightsailDiskAttachment_basic
=== PAUSE TestAccLightsailDiskAttachment_basic
=== RUN   TestAccLightsailDiskAttachment_disappears
=== PAUSE TestAccLightsailDiskAttachment_disappears
=== RUN   TestAccLightsailDisk_basic
=== PAUSE TestAccLightsailDisk_basic
=== RUN   TestAccLightsailDisk_Tags
=== PAUSE TestAccLightsailDisk_Tags
=== RUN   TestAccLightsailDisk_disappears
=== PAUSE TestAccLightsailDisk_disappears
=== CONT  TestAccLightsailDiskAttachment_basic
=== CONT  TestAccLightsailDisk_Tags
=== CONT  TestAccLightsailDisk_basic
=== CONT  TestAccLightsailDisk_disappears
--- PASS: TestAccLightsailDisk_disappears (58.75s)
=== CONT  TestAccLightsailDiskAttachment_disappears
--- PASS: TestAccLightsailDisk_basic (64.33s)
--- PASS: TestAccLightsailDisk_Tags (104.94s)
--- PASS: TestAccLightsailDiskAttachment_basic (239.24s)
--- PASS: TestAccLightsailDiskAttachment_disappears (211.77s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lightsail	272.301s
% make t T=TestAccLightsailInstance_ K=lightsail P=4
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 4 -run='TestAccLightsailInstance_'  -timeout 180m
=== RUN   TestAccLightsailInstance_basic
=== PAUSE TestAccLightsailInstance_basic
=== RUN   TestAccLightsailInstance_name
=== PAUSE TestAccLightsailInstance_name
=== RUN   TestAccLightsailInstance_tags
=== PAUSE TestAccLightsailInstance_tags
=== RUN   TestAccLightsailInstance_IPAddressType
=== PAUSE TestAccLightsailInstance_IPAddressType
=== RUN   TestAccLightsailInstance_addOn
=== PAUSE TestAccLightsailInstance_addOn
=== RUN   TestAccLightsailInstance_availabilityZone
    instance_test.go:283: skipping test; environment variable TF_AWS_LIGHTSAIL_AVAILABILITY_ZONE must be set. Usage: The availability zone that is outside the providers current region.
--- SKIP: TestAccLightsailInstance_availabilityZone (0.00s)
=== RUN   TestAccLightsailInstance_disappears
=== PAUSE TestAccLightsailInstance_disappears
=== CONT  TestAccLightsailInstance_basic
=== CONT  TestAccLightsailInstance_IPAddressType
=== CONT  TestAccLightsailInstance_tags
=== CONT  TestAccLightsailInstance_disappears
--- PASS: TestAccLightsailInstance_disappears (71.04s)
=== CONT  TestAccLightsailInstance_addOn
--- PASS: TestAccLightsailInstance_basic (73.07s)
=== CONT  TestAccLightsailInstance_name
--- PASS: TestAccLightsailInstance_tags (95.66s)
--- PASS: TestAccLightsailInstance_IPAddressType (105.65s)
--- PASS: TestAccLightsailInstance_name (199.41s)
--- PASS: TestAccLightsailInstance_addOn (284.76s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lightsail	357.582s
% make t T=TestAccLightsailLoadBalancer_serial K=lightsail
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20 -run='TestAccLightsailLoadBalancer_serial'  -timeout 180m
=== RUN   TestAccLightsailLoadBalancer_serial
=== PAUSE TestAccLightsailLoadBalancer_serial
=== CONT  TestAccLightsailLoadBalancer_serial
=== RUN   TestAccLightsailLoadBalancer_serial/lb_stickiness_policy
=== RUN   TestAccLightsailLoadBalancer_serial/lb_stickiness_policy/disappears
=== RUN   TestAccLightsailLoadBalancer_serial/lb_stickiness_policy/basic
=== RUN   TestAccLightsailLoadBalancer_serial/lb_stickiness_policy/cookie_duration
=== RUN   TestAccLightsailLoadBalancer_serial/lb_stickiness_policy/enabled
=== RUN   TestAccLightsailLoadBalancer_serial/lb
=== RUN   TestAccLightsailLoadBalancer_serial/lb/basic
=== RUN   TestAccLightsailLoadBalancer_serial/lb/disappears
=== RUN   TestAccLightsailLoadBalancer_serial/lb/name
=== RUN   TestAccLightsailLoadBalancer_serial/lb/health_check_path
=== RUN   TestAccLightsailLoadBalancer_serial/lb/tags
=== RUN   TestAccLightsailLoadBalancer_serial/lb_attachment
=== RUN   TestAccLightsailLoadBalancer_serial/lb_attachment/disappears
=== RUN   TestAccLightsailLoadBalancer_serial/lb_attachment/basic
=== RUN   TestAccLightsailLoadBalancer_serial/lb_certificate
=== RUN   TestAccLightsailLoadBalancer_serial/lb_certificate/basic
=== RUN   TestAccLightsailLoadBalancer_serial/lb_certificate/disappears
=== RUN   TestAccLightsailLoadBalancer_serial/lb_certificate/domain_validation_records
=== RUN   TestAccLightsailLoadBalancer_serial/lb_certificate/subject_alternative_names
=== RUN   TestAccLightsailLoadBalancer_serial/lb_certificate_attachment
=== RUN   TestAccLightsailLoadBalancer_serial/lb_certificate_attachment/basic
=== RUN   TestAccLightsailLoadBalancer_serial/lb_https_redirection_policy
=== RUN   TestAccLightsailLoadBalancer_serial/lb_https_redirection_policy/basic
--- PASS: TestAccLightsailLoadBalancer_serial (3853.95s)
    --- PASS: TestAccLightsailLoadBalancer_serial/lb_stickiness_policy (712.12s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_stickiness_policy/disappears (174.29s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_stickiness_policy/basic (166.05s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_stickiness_policy/cookie_duration (196.11s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_stickiness_policy/enabled (175.67s)
    --- PASS: TestAccLightsailLoadBalancer_serial/lb (945.69s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb/basic (154.28s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb/disappears (136.96s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb/name (278.23s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb/health_check_path (185.23s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb/tags (190.99s)
    --- PASS: TestAccLightsailLoadBalancer_serial/lb_attachment (1077.90s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_attachment/disappears (533.07s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_attachment/basic (544.83s)
    --- PASS: TestAccLightsailLoadBalancer_serial/lb_certificate (798.91s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_certificate/basic (201.14s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_certificate/disappears (191.98s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_certificate/domain_validation_records (194.30s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_certificate/subject_alternative_names (211.50s)
    --- PASS: TestAccLightsailLoadBalancer_serial/lb_certificate_attachment (181.03s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_certificate_attachment/basic (181.03s)
    --- PASS: TestAccLightsailLoadBalancer_serial/lb_https_redirection_policy (138.29s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_https_redirection_policy/basic (138.29s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lightsail	3855.789s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/lightsail Issues and PRs that pertain to the lightsail service. labels Sep 11, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 11, 2023
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Sep 11, 2023
@YakDriver YakDriver merged commit dd0a070 into main Sep 11, 2023
60 checks passed
@YakDriver YakDriver deleted the b-lightsail-fix-name-validation branch September 11, 2023 17:13
@github-actions github-actions bot added this to the v5.17.0 milestone Sep 11, 2023
github-actions bot pushed a commit that referenced this pull request Sep 11, 2023
Update CHANGELOG.md for #33405
3d8f7d8
@ewbankkit
Copy link
Contributor 

% make testacc TESTARGS='-run=_basic$$' PKG=lightsail ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 2  -run=_basic$ -timeout 180m
=== RUN   TestAccLightsailBucketAccessKey_basic
=== PAUSE TestAccLightsailBucketAccessKey_basic
=== RUN   TestAccLightsailBucketResourceAccess_basic
=== PAUSE TestAccLightsailBucketResourceAccess_basic
=== RUN   TestAccLightsailBucket_basic
=== PAUSE TestAccLightsailBucket_basic
=== RUN   TestAccLightsailCertificate_basic
=== PAUSE TestAccLightsailCertificate_basic
=== RUN   TestAccLightsailContainerServiceDeploymentVersion_container_basic
=== PAUSE TestAccLightsailContainerServiceDeploymentVersion_container_basic
=== RUN   TestAccLightsailContainerService_basic
=== PAUSE TestAccLightsailContainerService_basic
=== RUN   TestAccLightsailDatabase_basic
=== PAUSE TestAccLightsailDatabase_basic
=== RUN   TestAccLightsailDiskAttachment_basic
=== PAUSE TestAccLightsailDiskAttachment_basic
=== RUN   TestAccLightsailDisk_basic
=== PAUSE TestAccLightsailDisk_basic
=== RUN   TestAccLightsailDomainEntry_basic
=== PAUSE TestAccLightsailDomainEntry_basic
=== RUN   TestAccLightsailDomain_basic
=== PAUSE TestAccLightsailDomain_basic
=== RUN   TestAccLightsailInstancePublicPorts_basic
=== PAUSE TestAccLightsailInstancePublicPorts_basic
=== RUN   TestAccLightsailInstance_basic
=== PAUSE TestAccLightsailInstance_basic
=== RUN   TestAccLightsailKeyPair_basic
=== PAUSE TestAccLightsailKeyPair_basic
=== RUN   TestAccLightsailStaticIPAttachment_basic
=== PAUSE TestAccLightsailStaticIPAttachment_basic
=== RUN   TestAccLightsailStaticIP_basic
=== PAUSE TestAccLightsailStaticIP_basic
=== CONT  TestAccLightsailBucketAccessKey_basic
=== CONT  TestAccLightsailDisk_basic
--- PASS: TestAccLightsailBucketAccessKey_basic (58.02s)
=== CONT  TestAccLightsailContainerServiceDeploymentVersion_container_basic
--- PASS: TestAccLightsailDisk_basic (61.25s)
=== CONT  TestAccLightsailDiskAttachment_basic
--- PASS: TestAccLightsailContainerServiceDeploymentVersion_container_basic (244.75s)
=== CONT  TestAccLightsailDatabase_basic
--- PASS: TestAccLightsailDiskAttachment_basic (246.73s)
=== CONT  TestAccLightsailContainerService_basic
--- PASS: TestAccLightsailContainerService_basic (109.43s)
=== CONT  TestAccLightsailBucket_basic
--- PASS: TestAccLightsailBucket_basic (39.21s)
=== CONT  TestAccLightsailCertificate_basic
--- PASS: TestAccLightsailCertificate_basic (92.54s)
=== CONT  TestAccLightsailBucketResourceAccess_basic
--- PASS: TestAccLightsailBucketResourceAccess_basic (164.51s)
=== CONT  TestAccLightsailInstance_basic
--- PASS: TestAccLightsailInstance_basic (95.12s)
=== CONT  TestAccLightsailStaticIP_basic
--- PASS: TestAccLightsailStaticIP_basic (24.59s)
=== CONT  TestAccLightsailStaticIPAttachment_basic
--- PASS: TestAccLightsailStaticIPAttachment_basic (73.81s)
=== CONT  TestAccLightsailKeyPair_basic
--- PASS: TestAccLightsailKeyPair_basic (31.66s)
=== CONT  TestAccLightsailDomain_basic
    acctest.go:876: skipping tests; AWS_DEFAULT_REGION (us-west-2) not supported. Supported: [us-east-1]
--- SKIP: TestAccLightsailDomain_basic (0.00s)
=== CONT  TestAccLightsailInstancePublicPorts_basic
--- PASS: TestAccLightsailInstancePublicPorts_basic (101.67s)
=== CONT  TestAccLightsailDomainEntry_basic
    acctest.go:876: skipping tests; AWS_DEFAULT_REGION (us-west-2) not supported. Supported: [us-east-1]
--- SKIP: TestAccLightsailDomainEntry_basic (0.00s)
--- PASS: TestAccLightsailDatabase_basic (849.18s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lightsail	1157.494s

@YakDriver YakDriver modified the milestones: v5.17.0, v5.16.2 Sep 11, 2023
@github-actions
Copy link

This functionality has been released in v5.16.2 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@YakDriver YakDriver mentioned this pull request Sep 20, 2023
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2023
@justinretzolk justinretzolk added the bug Addresses a defect in current functionality. label Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/lightsail Issues and PRs that pertain to the lightsail service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v5.16.2
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_lightsail_instance, name verification always fails.
3 participants
@YakDriver @ewbankkit @justinretzolk